[16/n] tensor engine: enum-ify PythonMessage #529
Closed
+272
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythonMessage was getting a bit stringly typed. I've sectioned into 4 enum case (CallMethod, Result, Exception, Uninit) which capture when you have to pay attention to things like rank/response_port. I have to further add functionality in a follow-up to get actor ordering correct. Differential Revision: [D78295683](https://our.internmc.facebook.com/intern/diff/D78295683/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 14, 2025
PythonMessage was getting a bit stringly typed. I've sectioned into 4 enum case (CallMethod, Result, Exception, Uninit) which capture when you have to pay attention to things like rank/response_port. I have to further add functionality in a follow-up to get actor ordering correct. Differential Revision: [D78295683](https://our.internmc.facebook.com/intern/diff/D78295683/) ghstack-source-id: 296136316 Pull Request resolved: #529
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78295683 |
PythonMessage was getting a bit stringly typed. I've sectioned into 4 enum case (CallMethod, Result, Exception, Uninit) which capture when you have to pay attention to things like rank/response_port. I have to further add functionality in a follow-up to get actor ordering correct. Differential Revision: [D78295683](https://our.internmc.facebook.com/intern/diff/D78295683/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 14, 2025
Pull Request resolved: #529 PythonMessage was getting a bit stringly typed. I've sectioned into 4 enum case (CallMethod, Result, Exception, Uninit) which capture when you have to pay attention to things like rank/response_port. I have to further add functionality in a follow-up to get actor ordering correct. Differential Revision: [D78295683](https://our.internmc.facebook.com/intern/diff/D78295683/) ghstack-source-id: 296146814
|
This pull request was exported from Phabricator. Differential Revision: D78295683 |
PythonMessage was getting a bit stringly typed. I've sectioned into 4 enum case (CallMethod, Result, Exception, Uninit) which capture when you have to pay attention to things like rank/response_port. I have to further add functionality in a follow-up to get actor ordering correct. Differential Revision: [D78295683](https://our.internmc.facebook.com/intern/diff/D78295683/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78295683 |
|
This pull request has been merged in 438a1e6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
PythonMessage was getting a bit stringly typed. I've sectioned into 4 enum case (CallMethod, Result, Exception, Uninit) which capture when you have to pay attention to things like rank/response_port.
I have to further add functionality in a follow-up to get actor ordering correct.
Differential Revision: D78295683